Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created parity algorithm #582

Closed
wants to merge 4 commits into from
Closed

Created parity algorithm #582

wants to merge 4 commits into from

Conversation

mrwolferinc
Copy link

I have decided to add an algorithm for finding the parity of a number because I feel like such an algorithm should be added to this repository.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@codecov
Copy link

codecov bot commented Nov 29, 2020

Codecov Report

Merging #582 (7fff602) into master (2c74ced) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #582   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          150       150           
  Lines         2627      2627           
  Branches       437       437           
=========================================
  Hits          2627      2627           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c74ced...24e4692. Read the comment docs.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@mrwolferinc mrwolferinc marked this pull request as ready for review November 29, 2020 20:14

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@mrwolferinc
Copy link
Author

Some checks haven’t completed yet

Codecov Report

Merging #582 (7fff602) into master (2c74ced) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #582   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          150       150           
  Lines         2627      2627           
  Branches       437       437           
=========================================
  Hits          2627      2627           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c74ced...24e4692. Read the comment docs.

Wrong branch! You are supposed to do a coverage report on the patch-2 branch!

@lazarljubenovic
Copy link

lazarljubenovic commented Dec 2, 2020

This is a terrible practice. To determine parity, use x % 2 for everyday code or x & 1 if you really wanna go low-level uber-performance. Also your definition of parity for fractions is ridiculous. Where did you find it?

@mrwolferinc
Copy link
Author

This is a terrible practice. To determine parity, use x % 2 for everyday code or x & 1 if you really wanna go low-level uber-performance. Also your definition of parity for fractions is ridiculous. Where did you find it?

Oh ok

@mrwolferinc mrwolferinc closed this Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants