Skip to content

Add rail fence cipher #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 20, 2020
Merged

Conversation

jprask
Copy link
Contributor

@jprask jprask commented Jul 28, 2020

Related to #406

@jprask jprask force-pushed the feature/rail-fence-cipher branch from 4715c7d to 58eaa43 Compare July 28, 2020 23:57
@jprask jprask changed the title Add rail fence cipher encoder & decoder Add rail fence cipher Jul 28, 2020
@codecov
Copy link

codecov bot commented Jul 29, 2020

Codecov Report

Merging #516 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #516   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          149       152    +3     
  Lines         2610      2650   +40     
  Branches       434       444   +10     
=========================================
+ Hits          2610      2650   +40     
Impacted Files Coverage Δ
.../cryptography/rail-fence-cipher/decodeRailFence.js 100.00% <100.00%> (ø)
.../cryptography/rail-fence-cipher/encodeRailFence.js 100.00% <100.00%> (ø)
.../cryptography/rail-fence-cipher/railFenceCipher.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f42433e...7881dfa. Read the comment docs.

* Add functions to encode & decode strings using the rail fence cipher method
* Add unit tests covering empty strings, pair & odd number of characters in the input string, n=3 & n=4
* Add a README.md for the algorithm
* Update root README.md to link to the new algorithm
@jprask jprask force-pushed the feature/rail-fence-cipher branch from 58eaa43 to 7881dfa Compare July 29, 2020 00:05

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@trekhleb trekhleb changed the base branch from master to merge December 20, 2020 17:39
@trekhleb
Copy link
Owner

Thanks for implementing it, @jprask

@trekhleb trekhleb merged commit 9641940 into trekhleb:merge Dec 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants