Skip to content

Fix the remove method for the MinHeap #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 5, 2018

Conversation

m-maksyutin
Copy link
Contributor

Previously the custom finding comparator was not fully used in the remove method.

@codecov-io
Copy link

codecov-io commented Jun 4, 2018

Codecov Report

Merging #50 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #50   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          86     86           
  Lines        1883   1883           
  Branches      332    332           
=====================================
  Hits         1883   1883
Impacted Files Coverage Δ
src/data-structures/heap/MinHeap.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f83862...f801f0a. Read the comment docs.

m-maksyutin and others added 2 commits June 5, 2018 08:25

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@trekhleb
Copy link
Owner

trekhleb commented Jun 5, 2018

Thank you for the fix @m-maksyutin !

@trekhleb trekhleb merged commit 38688f2 into trekhleb:master Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants