Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix recursion issues in algorithms/sets/combination-sum #458

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+65 −68
Open

Fix recursion issues in algorithms/sets/combination-sum #458

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3b9a358
Refactor combinationSum to an iterative algo
cascandaliato Jan 30, 2020
f6408ff
Add test cases mentioned in #308
cascandaliato Jan 30, 2020
2f60cab
Update combinationSum README to reflect new implementation
cascandaliato Jan 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add test cases mentioned in #308
@cascandaliato
cascandaliato authored Jan 30, 2020

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
commit f6408ffb57a13a5f5acdc8dc121f38fda1b6341b
10 changes: 10 additions & 0 deletions src/algorithms/sets/combination-sum/__test__/combinationSum.test.js
View file
Original file line number Diff line number Diff line change
@@ -2,6 +2,16 @@ import combinationSum from '../combinationSum';

describe('combinationSum', () => {
it('should find all combinations with specific sum', () => {
expect(combinationSum([1], 100000)).toHaveLength(1);

expect(
combinationSum([1], 100000)[0]
.every(el => el === 1),
)
.toBe(true);

expect(combinationSum([0, 2], 6)).toEqual([[2, 2, 2]]);

expect(combinationSum([1], 4)).toEqual([
[1, 1, 1, 1],
]);