Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix: #378 Removing Redundant Condition #379

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

ram-nad
Copy link

@ram-nad ram-nad commented Aug 7, 2019

The code will now throw error if someone tries to index values less than 1.
Also code still works for n == 1 case.

ram-nad added 7 commits August 7, 2019 21:50

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@codecov
Copy link

codecov bot commented Aug 7, 2019

Codecov Report

Merging #379 into master will decrease coverage by 0.07%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #379      +/-   ##
==========================================
- Coverage     100%   99.92%   -0.08%     
==========================================
  Files         149      149              
  Lines        2612     2612              
  Branches      434      434              
==========================================
- Hits         2612     2610       -2     
- Misses          0        2       +2
Impacted Files Coverage Δ
src/algorithms/math/fibonacci/fibonacciNth.js 90% <50%> (-10%) ⬇️
src/algorithms/math/fibonacci/fibonacci.js 91.66% <50%> (-8.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc1047d...bf504fc. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 7, 2019

Codecov Report

Merging #379 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #379   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files         149    149           
  Lines        2612   2612           
  Branches      434    434           
=====================================
  Hits         2612   2612
Impacted Files Coverage Δ
src/algorithms/math/fibonacci/fibonacciNth.js 100% <100%> (ø) ⬆️
src/algorithms/math/fibonacci/fibonacci.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc1047d...f547721. Read the comment docs.

ram-nad added 4 commits August 7, 2019 22:28

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@ram-nad
Copy link
Author

ram-nad commented Aug 7, 2019

Also added the tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant