-
-
Notifications
You must be signed in to change notification settings - Fork 30.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix: #378 Removing Redundant Condition #379
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #379 +/- ##
==========================================
- Coverage 100% 99.92% -0.08%
==========================================
Files 149 149
Lines 2612 2612
Branches 434 434
==========================================
- Hits 2612 2610 -2
- Misses 0 2 +2
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #379 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 149 149
Lines 2612 2612
Branches 434 434
=====================================
Hits 2612 2612
Continue to review full report at Codecov.
|
Also added the tests |
The code will now throw error if someone tries to index values less than 1.
Also code still works for n == 1 case.