Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Algorithm for conversion of binary to decimal and vice versa #372

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

akshaycb
Copy link

@akshaycb akshaycb commented Jul 8, 2019

Hi, good to see javascript data-structures and algorithms stacked at one place. So thought of contributing to it.
I added algorithms for conversion of a binary number to decimal number and vice versa in algorithms/math/binary directory. Let me know if it sounds good.

akshaycb added 3 commits July 8, 2019 11:12

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@codecov
Copy link

codecov bot commented Jul 8, 2019

Codecov Report

Merging #372 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #372   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files         149    151    +2     
  Lines        2612   2637   +25     
  Branches      434    438    +4     
=====================================
+ Hits         2612   2637   +25
Impacted Files Coverage Δ
src/algorithms/math/binary/decimalToBinary.js 100% <100%> (ø)
src/algorithms/math/binary/binaryToDecimal.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc1047d...46be0ac. Read the comment docs.

@akshaycb akshaycb force-pushed the algorithm-for-conversion-of-binary-to-decimal-and-vice-versa branch from ff51dfa to ef5951f Compare July 8, 2019 19:05
@akshaycb
Copy link
Author

Hi @trekhleb,
Any updates or suggestions on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant