Simplify dpMaximumSubarray #189
Merged
+30
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
appleJax
force-pushed
the
refactor/dpMaximumSubarray
branch
from
47d79d7 to
bcaf3ef
Compare
|
@appleJax thank you for simplification. |
harshes53
pushed a commit
to harshes53/javascript-algorithms
that referenced
this pull request
Dec 6, 2018
* Simplify dpMaximumSubarray * change var name from currentMaxSum to currentSum * fix comment with old variable name
shoredata
pushed a commit
to shoredata/javascript-algorithms
that referenced
this pull request
Mar 28, 2019
* Simplify dpMaximumSubarray * change var name from currentMaxSum to currentSum * fix comment with old variable name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternate PR to #160
Changes:
maxSubarrayat the end, rather than keeping a greedy copy ofmaxSubarray