Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create anagram.js #182

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Create anagram.js #182

wants to merge 5 commits into from

Conversation

AnishTiwari
Copy link

two strings are anagram or not

AnishTiwari and others added 3 commits August 27, 2018 21:27

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
two strings are anagram or not

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@trekhleb
Copy link
Owner

trekhleb commented Sep 8, 2018

@AnishTiwari thank you for the PR. Could you please fix ESLint errors that are mentioned here and also cover your code with tests?

@ocnly
Copy link
Contributor

ocnly commented Sep 16, 2018

The problem could be with if (anagram(word1,word2)) on line 18, where word1 and word2 are undefined.

@AnishTiwari
Copy link
Author

AnishTiwari commented Sep 16, 2018 via email

@ocnly
Copy link
Contributor

ocnly commented Sep 17, 2018

@AnishTiwari No worries, the code was correct except for line 18, which should be:
if(anagram("binary", "brainy")){
You can delete line 24 as it is not used, and you may try to work on the indentation too.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@AnishTiwari
Copy link
Author

AnishTiwari commented Sep 18, 2018 via email

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants