Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add N queens problem bitwise solution #15

Merged
merged 4 commits into from
Aug 20, 2018

Conversation

juffalow
Copy link
Contributor

No description provided.

Copy link
Owner

@trekhleb trekhleb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please revert all changes in README.md and make tests to pass along with Eslint?

@uccv
Copy link

uccv commented May 29, 2018

Are the n items horizontal or vertical ?

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@codecov-io
Copy link

codecov-io commented May 30, 2018

Codecov Report

Merging #15 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #15   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files         117    118    +1     
  Lines        2283   2296   +13     
  Branches      396    397    +1     
=====================================
+ Hits         2283   2296   +13
Impacted Files Coverage Δ
...s/uncategorized/n-queens-bitwise/nQueensBitwise.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecc8c65...62a8c74. Read the comment docs.

@juffalow
Copy link
Contributor Author

Hi! I reverted the changes and updated the code to be ok with eslint rules.

@emesbee
Copy link

emesbee commented Jun 23, 2018

How does this work?

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@trekhleb trekhleb changed the base branch from master to n-queens-bitwise August 20, 2018 12:56
@trekhleb
Copy link
Owner

Thank you for PR @juffalow

@trekhleb trekhleb merged commit 18ba3a4 into trekhleb:n-queens-bitwise Aug 20, 2018
harshes53 referenced this pull request in harshes53/javascript-algorithms Dec 6, 2018
* Add N queens problem bitwise solution

* Update code to corespond with eslint
shoredata pushed a commit to shoredata/javascript-algorithms that referenced this pull request Mar 28, 2019
* Add N queens problem bitwise solution

* Update code to corespond with eslint
GohJunLe added a commit to zhiwei8/javascript-algorithms that referenced this pull request Aug 31, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Create newCI.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants