Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added implementatin for kadane's algorithm #1031

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
+33 −0
Open

Added implementatin for kadane's algorithm #1031

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4e2d751
added implementatin of kadane's algorithm
sundaram123krishnan Apr 16, 2023
5bd5f80
fixed an error in max function
sundaram123krishnan Apr 16, 2023
d641025
the search goes from 1 to array.length
sundaram123krishnan Apr 16, 2023
b51df2b
added explanations
sundaram123krishnan Apr 16, 2023
65ecad8
Fixed function parameters
sundaram123krishnan Apr 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
the search goes from 1 to array.length
@sundaram123krishnan
sundaram123krishnan committed Apr 16, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
commit d64102563dca097d9e1ea36b3681d4aea9d62e45
2 changes: 1 addition & 1 deletion src/algorithms/uncategorized/kadane's algorithm/kadane_algo.js
View file
Original file line number Diff line number Diff line change
@@ -9,7 +9,7 @@ export default function kadane() {
let current_sum = array[0];
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is array?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing out , i forgot to add parameter to function.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
let current_sum = array[0];
let current_sum = array[0] ?? 0;

let maximum_subarray_sum = array[0];
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
let maximum_subarray_sum = array[0];
let maximum_subarray_sum = array[0] ?? -Infinity;

or

Suggested change
let maximum_subarray_sum = array[0];
let maximum_subarray_sum = array[0] ?? - Math.pow(2, 53) - 1;


for (let i = 0; i < array.length; i++) {
for (let i = 1; i < array.length; i++) {
current_sum = Math.max(current_sum + array[i], array[i]);
maximum_subarray_sum = Math.max(maximum_subarray_sum, current_sum);
}