Fix CountingSort for negative numbers #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #100 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 115 115
Lines 2252 2255 +3
Branches 390 391 +1
=====================================
+ Hits 2252 2255 +3
Continue to review full report at Codecov.
|
|
Thank you for your PR @dubzzz |
shoredata
pushed a commit
to shoredata/javascript-algorithms
that referenced
this pull request
Mar 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to run property based tests on the sorting algorithms available in javascript-algorithms, I detected sorting issues on CountingSort and RadixSort with arrays having negative entries.
Here is a fix to be able to handle negative integers in CountingSort.
The commit adding property based tests to the sorting algorithms is available at dubzzz@34b0c46
If you are interested in such testing approach I can issue another pull request to add those tests too.