fix fileName - undefined and fileType not present in s3 upload objects #5680
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Murderlon while trying to reproduce and fix #5666 , #5667
I came across this bug , where uploading a file from the example code provided at
examples/aws-nodejs/public/index.html
resulted in uploaded files with undefined_name in instead of fileName in the S3 key as well as no fileType present
reference -
this was because while making the request to /s3/params to get the signed URL , it parses the fileName and contentType from the request body to append it to the Key
uppy/examples/aws-nodejs/index.js
Lines 107 to 121 in f877dac
but in default case (without the customEndpoint) it's a GET request which causes this error as we're trying to parse the fileName and contentType from req body ,
uppy/packages/@uppy/aws-s3/src/index.ts
Lines 659 to 665 in f877dac
After :
File uploaded with correct fileName and correct fileType