Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nb_NO.ts #5678

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update nb_NO.ts #5678

wants to merge 2 commits into from

Conversation

toresbe
Copy link

@toresbe toresbe commented Mar 5, 2025

In Norwegian grammatical rules, a comma is used in lists of three or more members. I noticed this one quickly because it's in the demo on your website.

Missing comma
Copy link
Contributor

github-actions bot commented Mar 5, 2025

Diff output files
diff --git a/packages/@uppy/locales/lib/nb_NO.js b/packages/@uppy/locales/lib/nb_NO.js
index e257ee1..f1ad3a0 100644
--- a/packages/@uppy/locales/lib/nb_NO.js
+++ b/packages/@uppy/locales/lib/nb_NO.js
@@ -51,9 +51,9 @@ nb_NO.strings = {
   dropPasteBoth: "Dra filer hit, %{browseFiles} eller %{browseFolders}",
   dropPasteFiles: "Dra filer hit eller %{browseFiles}",
   dropPasteFolders: "Dra filer hit eller %{browseFolders}",
-  dropPasteImportBoth: "Dra filer hit %{browseFiles}, %{browseFolders} eller importer fra:",
-  dropPasteImportFiles: "Dra filer hit %{browseFiles} eller importer fra:",
-  dropPasteImportFolders: "Dra filer hit %{browseFolders} eller importer fra:",
+  dropPasteImportBoth: "Dra filer hit, %{browseFiles}, %{browseFolders} eller importer fra:",
+  dropPasteImportFiles: "Dra filer hit, %{browseFiles} eller importer fra:",
+  dropPasteImportFolders: "Dra filer hit, %{browseFolders} eller importer fra:",
   editFile: "Rediger fil",
   editImage: "Rediger bilde",
   editing: "Redigerer %{file}",

Norwegian does not use commas in lists of two members, so I've walked
that one back.

Also, I missed a resource where a comma is required.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant