fix: use path instead of filepath #1685
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, yaegi uses the
filepathpackage to join paths.However, this has issues: YAEGI uses an
fs.FSinternally for source code access, andfsspecifies that/separated paths must be used. On Unix systems, this obviously makes no difference; but on Windows, with a non-default FS, this causes errors (since YAEGI creates\separated paths, but the FS expects/separated paths).Furthermore, generally speaking, Golang import paths and the like are always
/separated anyway, regardless of OS.To clear this up, this PR changes path handling to
/separated paths. This has the advantage of being accepted by all OS (even Windows will accept/separated paths). Paths passed by the user toCompilePathor similar are changed to/separators, if necessary.