-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: search first character of each word #644
feat: search first character of each word #644
Conversation
It matches non-word characters currently. For example for string "Delete file & next" it'll create a keyword |
And yeah, title and hint probably shouldn't be concatenated, but matched separately. |
9ea9432
to
92821ce
Compare
We could go with a simple |
8a385fc
to
09cf2e8
Compare
I've made a list with word separators, I hope I got everyone's favorite word separation characters in there. |
Add And I guess put |
d1e11cb
to
49ae91f
Compare
|
Oh, and
Yeah that would be nice. |
e201373
to
6e9b953
Compare
I missed so many characters 😞 |
6e9b953
to
c2c2d0c
Compare
amazing work guys, i really appreciate it |
I don't really understand why title and hint characters should be concatenated.
It might make some sense when the title is only one word, but otherwise it might lead to unexpected results.
I tried also a different implementation based on
find
instead ofgmatch
that I expected to be faster, because it only allocated half as many strings, but it turned out to be the same speed.Ref. #625 (comment)