axum-macros: move from_request.rs to from_request/mod.rs #3163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jplatte
reviewed
Jan 8, 2025
There was a problem hiding this comment.
I don't like how most of the diff is about files that clippy had false-positives on. Let's just rename the axum-macros file and not enable the lint for now?
Found some existing bug reports, this one has most detail I think: rust-lang/rust-clippy#11916
mladedav
force-pushed
the
dm/self-named-module-files-lint
branch
2 times, most recently
from
44fb6ff to
e6cc5f2
Compare
|
Yeah, I agree. |
mladedav
force-pushed
the
dm/self-named-module-files-lint
branch
from
e6cc5f2 to
477c36a
Compare
mladedav
force-pushed
the
dm/self-named-module-files-lint
branch
from
477c36a to
539b592
Compare
jplatte
approved these changes
Jan 8, 2025
mladedav
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to use
mod.rsif we already have a directory with the same name.Solution
Move the file.