Trailing slashes with encoded characters. #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanhammond
force-pushed
the
trailing-slashes
branch
from
fe330f6 to
1d2811f
Compare
trentmwillis
approved these changes
Sep 27, 2016
nathanhammond
added a commit
to nathanhammond/ember.js
that referenced
this pull request
Sep 27, 2016
Trailing slashes with encoded chars did not previously work. See: tildeio/route-recognizer#114
rwjblue
pushed a commit
to emberjs/ember.js
that referenced
this pull request
Sep 28, 2016
Trailing slashes with encoded chars did not previously work. See: tildeio/route-recognizer#114 (cherry picked from commit 66cb3b0)
rwjblue
pushed a commit
to emberjs/ember.js
that referenced
this pull request
Sep 28, 2016
Trailing slashes with encoded chars did not previously work. See: tildeio/route-recognizer#114 (cherry picked from commit 66cb3b0)
nathanhammond
added a commit
to nathanhammond/ember-route-recognizer
that referenced
this pull request
Oct 4, 2016
webark
pushed a commit
to webark/ember.js
that referenced
this pull request
Oct 6, 2016
Trailing slashes with encoded chars did not previously work. See: tildeio/route-recognizer#114
mixonic
pushed a commit
to mixonic/ember.js
that referenced
this pull request
Oct 22, 2016
Trailing slashes with encoded chars did not previously work. See: tildeio/route-recognizer#114
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As identified by Vaanan Vetrivel Kannan, we don't currently handle path length correctly when dealing with encoded characters.
This adds a failing test and a fix.