Disable requiring mocha directly in browser environments #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robdel12
approved these changes
Feb 5, 2018
cowboyd
approved these changes
Feb 5, 2018
wwilsman
force-pushed
the
ww/mocha-shim
branch
from
884a6c2 to
35cb830
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The mocha entrypoint has not yet been optimized to work with browser bundles without first disabling certain node modules.
mochajs/mocha#2448
Approach
In a browser environment, mocha is usually included before the tests and has defined it's functions within the global context. Requiring mocha directly is now disabled in browser environments via the
browserfield in this package'spackage.jsonfile.Added a
mocha.jsfile which imports all of mocha's exports, and defaults the relevant ones with the defined globals. Since mocha is now disabled for browsers, this will effectively export the globally defined mocha functions as named exports.