feat(Input): migrate to new design #1248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
AnastasiiaMP
force-pushed
the
ONEUI-455-migrate-input-component
branch
from
f200dff to
c5f23ff
Compare
|
Please add comment to the PR about breaking changes. Those then should be copied to the commit message when the branch is merged, so that semver correctly tags the next release and change logs are updates as needed. See CONTRIBUTING.md for details |
|
@eszthoff I've added breaking changes, please, have a look and let me know if you have any questions. Thank you! |
eszthoff
suggested changes
Sep 5, 2024
eszthoff
suggested changes
Sep 6, 2024
eszthoff
approved these changes
Sep 6, 2024
eszthoff
suggested changes
Sep 6, 2024
eszthoff
approved these changes
Sep 6, 2024
added 18 commits
September 10, 2024 15:35
AnastasiiaMP
force-pushed
the
ONEUI-455-migrate-input-component
branch
from
6aced3a to
d037908
Compare
AnastasiiaMP
force-pushed
the
ONEUI-455-migrate-input-component
branch
from
d037908 to
ad800ec
Compare
AnastasiiaMP
added a commit
that referenced
this pull request
Sep 10, 2024
* feat: migrate input component to new design * chore: make error message obligatory when context is critical * fix: remove optional sign from context prop * refactor: change the naming * chore: add extra check for error message * fix: make label optional * fix: address review comments * chore: add possibility to unselect the context in storybook * style: remove focus state from critical context * refactor: change type for the context * chore: add possibility to use custom id * fix: remove unnesasary comment * refactor: remove isActive state * chore: add space to the error message * style: put old naming back * refactor: make naming more understandable * refactor: avoid nested tenantry * refactor: better solution for nested tenantry * fix avoid jumping width/content on focus and critical --------- Co-authored-by: Anastasiia Mishchenko <[email protected]>
6 tasks
AnastasiiaMP
added a commit
that referenced
this pull request
Sep 10, 2024
BREAKING CHANGE: `size` prop is limited to `small` or `medium`, with `medium` as the default, replace size="large" or omitting size (previously defaulting to `normal`) with size="medium", or use size="small" as needed BREAKING CHANGE: `context` prop only accepts `critical`. Remove any usage of `brand` or `success` context. Provide `errorMessage` if critical context is expected BREAKING CHANGE: replace any custom methods for setting inputs as non-editable with new prop `readOnly` BREAKING CHANGE: replace existing approaches for displaying helper text with the new `helperText` prop BREAKING CHANGE: use the `label` prop for input labels, replacing any previous label handling BREAKING CHANGE: use the `reserveErrorMessageSpace` prop to determine whether space should be reserved for error message under the input field when validation is expected, especially if no helper text is present
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ONEUI-455
BREAKING CHANGE: Input component props size, context, and additional states are updated
smallormedium, withmediumas the default. The optionslargeandnormalhave been removed. Replace size="large" or omitting size (previously defaulting tonormal) with size="medium", or use size="small" as needed.critical. Other contexts likebrandorsuccessare removed. For critical contexts, use context="critical" and provide an errorMessage.readOnlyprop added to specify if the input field should be non-editable. Replace any custom methods for setting inputs as non-editable with readOnly={true}.reserveErrorMessageSpaceprop added determine whether space should be reserved for error messages under the input field when validation is expected to avoid "jumping" UI. Default tofalse.Checklist