feat(Select): added option for no default selection

[mukiienko]

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. Use imperative, present tense in your commit description ("change", not "changed" or "changes") without uppercases or period (.) at the end.

Checklist

• The implementation has been manually tested and complies with Textkernel browser support guidelines
• The implementation complies with accessibility standards.
• The component has a displayName defined.
• The component comes with a detailed PropTypes (and defaultProps) definition.
• Component PropTypes are sufficiently described / documented.
• There is a story in Storybook.

[eszthoff]

When I tried tested the onFocus call: it works in the clearable version as expected. but in the simple implementation for some reason, clicking on the icon directly doesn't trigger onFocus. Can you have a look?

[eszthoff]

Maybe it is too late for this point, but I wonder why you decided to implement the arrow in FieldWrapper / SelectBase that is used in different places and not in the Select itself, as it was before, and as it is done in Combobox for instance.

[mukiienko]

Maybe it is too late for this point, but I wonder why you decided to implement the arrow in FieldWrapper / SelectBase that is used in different places and not in the Select itself, as it was before, and as it is done in Combobox for instance.

The "clear" button is implemented FieldWrapper and it is hard to combine "clear" and "arrow" buttons together if they are in different components.

[mukiienko]

When I tried tested the onFocus call: it works in the clearable version as expected. but in the simple implementation for some reason, clicking on the icon directly doesn't trigger onFocus. Can you have a look?

Fixed, now it works for the both implementations. These changes also fixed onFocus test.

[eszthoff]

Maybe it is too late for this point, but I wonder why you decided to implement the arrow in FieldWrapper / SelectBase that is used in different places and not in the Select itself, as it was before, and as it is done in Combobox for instance.

The "clear" button is implemented FieldWrapper and it is hard to combine "clear" and "arrow" buttons together if they are in different components.

should we use this option also in Combobox? maybe it is a quick fix can be done here, or if not, create a followup story (that we will never pick up with the current pace, but at least have a record for future generations :-P )

[eszthoff]

Last thing, I think the PR title / commit message after squash should be feat(Select): added option for no default selection. Something like that, main point being:

• Select is included right after feat
• better be specific of what 'improvements' were made

[mukiienko]

Maybe it is too late for this point, but I wonder why you decided to implement the arrow in FieldWrapper / SelectBase that is used in different places and not in the Select itself, as it was before, and as it is done in Combobox for instance.

The "clear" button is implemented FieldWrapper and it is hard to combine "clear" and "arrow" buttons together if they are in different components.

should we use this option also in Combobox? maybe it is a quick fix can be done here, or if not, create a followup story (that we will never pick up with the current pace, but at least have a record for future generations :-P )

It makes sense, I already was trying to do that, but it requires some changes in Combobox. I created task for refactoring ONEUI-303