feat: addressed review points

textkernel · May 4, 2022 · f73c11c · f73c11c
1 parent c9603b2
commit f73c11c
Show file tree

Hide file tree

Showing 14 changed files with 920 additions and 784 deletions.
diff --git a/...mponents/AutosuggestDeprecated/__tests__/__snapshots__/AutosuggestDeprecated.spec.js.snap b/...mponents/AutosuggestDeprecated/__tests__/__snapshots__/AutosuggestDeprecated.spec.js.snap
@@ -59,7 +59,7 @@ exports[`AutosuggestDeprecated rendering should initially render empty component
           className="AutosuggestDeprecated__field"
           clearLabel="Clear"
           disabled={false}
-          isArrowDropUp={false}
+          isArrowUp={false}
           isFocused={false}
           onClear={[Function]}
           onClick={[Function]}
@@ -180,7 +180,7 @@ exports[`AutosuggestDeprecated rendering should render all suggestions from the
           className="AutosuggestDeprecated__field"
           clearLabel="Clear"
           disabled={false}
-          isArrowDropUp={false}
+          isArrowUp={false}
           isFocused={true}
           onClear={[Function]}
           onClick={[Function]}
@@ -491,7 +491,7 @@ exports[`AutosuggestDeprecated rendering should render icon correctly if passed
           className="AutosuggestDeprecated__field"
           clearLabel="Clear"
           disabled={false}
-          isArrowDropUp={false}
+          isArrowUp={false}
           isFocused={false}
           onClear={[Function]}
           onClick={[Function]}
@@ -664,7 +664,7 @@ exports[`AutosuggestDeprecated rendering should render noSuggestions placeholder
           className="AutosuggestDeprecated__field"
           clearLabel="Clear"
           disabled={false}
-          isArrowDropUp={false}
+          isArrowUp={false}
           isFocused={true}
           onClear={[Function]}
           onClick={[Function]}
@@ -833,7 +833,7 @@ exports[`AutosuggestDeprecated rendering should render suggestions also if it pa
           className="AutosuggestDeprecated__field"
           clearLabel="Clear"
           disabled={false}
-          isArrowDropUp={false}
+          isArrowUp={false}
           isFocused={true}
           onClear={[Function]}
           onClick={[Function]}

diff --git a/src/components/FieldWrapper/FieldWrapper.tsx b/src/components/FieldWrapper/FieldWrapper.tsx
@@ -12,7 +12,7 @@ interface Props extends React.HTMLAttributes<HTMLDivElement> {
     /** show dropdown icon */
     showArrow?: boolean;
     /** set direction of dropdown icon (default drop down) */
-    isArrowDropUp?: boolean;
+    isArrowUp?: boolean;
     /** show Clear button on hover even if there are no selectedSuggestions passed */
     showClearButton?: boolean;
     /** clear button label */
@@ -38,7 +38,7 @@ export const FieldWrapper: React.FC<Props> = React.forwardRef((props, ref) => {
     const {
         children,
         showArrow,
-        isArrowDropUp,
+        isArrowUp,
         clearLabel,
         showClearButton,
         onClear,
@@ -62,7 +62,7 @@ export const FieldWrapper: React.FC<Props> = React.forwardRef((props, ref) => {
             )}
 
             {showArrow &&
-                (isArrowDropUp ? (
+                (isArrowUp ? (
                     <IoMdArrowDropup {...elem('dropdownIcon')} />
                 ) : (
                     <IoMdArrowDropdown {...elem('dropdownIcon')} />
@@ -75,7 +75,7 @@ FieldWrapper.displayName = 'FieldWrapper';
 
 FieldWrapper.defaultProps = {
     showArrow: false,
-    isArrowDropUp: false,
+    isArrowUp: false,
     showClearButton: false,
     clearLabel: '',
     onClear: null,

diff --git a/src/components/FieldWrapper/__tests__/FieldWrapper.spec.js b/src/components/FieldWrapper/__tests__/FieldWrapper.spec.js
@@ -4,7 +4,7 @@ import { FieldWrapper } from '../FieldWrapper';
 
 describe('FieldWrapper', () => {
     it('should render correctly', () => {
-        const wrapper = mount(<FieldWrapper showArrow>some children</FieldWrapper>);
+        const wrapper = mount(<FieldWrapper>some children</FieldWrapper>);
 
         expect(toJson(wrapper)).toMatchSnapshot();
         expect(wrapper.find('button')).toHaveLength(0);
@@ -19,6 +19,20 @@ describe('FieldWrapper', () => {
         expect(toJson(wrapper)).toMatchSnapshot();
         expect(wrapper.find('button')).toHaveLength(1);
     });
+    it('should render arrow icon pointing down', () => {
+        const wrapper = mount(<FieldWrapper showArrow>some children</FieldWrapper>);
+
+        expect(toJson(wrapper)).toMatchSnapshot();
+    });
+    it('should render arrow icon pointing up', () => {
+        const wrapper = mount(
+            <FieldWrapper showArrow isArrowUp>
+                some children
+            </FieldWrapper>
+        );
+
+        expect(toJson(wrapper)).toMatchSnapshot();
+    });
     it('should call onClear callback correctly', () => {
         const onClearMock = jest.fn();
         const wrapper = mount(

diff --git a/src/components/FieldWrapper/__tests__/__snapshots__/FieldWrapper.spec.js.snap b/src/components/FieldWrapper/__tests__/__snapshots__/FieldWrapper.spec.js.snap
@@ -4,7 +4,7 @@ exports[`FieldWrapper should add clear button if showClearButton is true 1`] = `
 <FieldWrapper
   clearLabel="Clear"
   disabled={false}
-  isArrowDropUp={false}
+  isArrowUp={false}
   isFocused={false}
   onClear={null}
   showArrow={false}
@@ -42,11 +42,11 @@ exports[`FieldWrapper should add clear button if showClearButton is true 1`] = `
 </FieldWrapper>
 `;
 
-exports[`FieldWrapper should render correctly 1`] = `
+exports[`FieldWrapper should render arrow icon pointing down 1`] = `
 <FieldWrapper
   clearLabel=""
   disabled={false}
-  isArrowDropUp={false}
+  isArrowUp={false}
   isFocused={false}
   onClear={null}
   showArrow={true}
@@ -97,3 +97,82 @@ exports[`FieldWrapper should render correctly 1`] = `
   </div>
 </FieldWrapper>
 `;
+
+exports[`FieldWrapper should render arrow icon pointing up 1`] = `
+<FieldWrapper
+  clearLabel=""
+  disabled={false}
+  isArrowUp={true}
+  isFocused={false}
+  onClear={null}
+  showArrow={true}
+  showClearButton={false}
+>
+  <div
+    className="FieldWrapper"
+    disabled={false}
+  >
+    <div
+      className="FieldWrapper__content"
+    >
+      some children
+    </div>
+    <IoMdArrowDropup
+      className="FieldWrapper__dropdownIcon"
+    >
+      <IconBase
+        attr={
+          Object {
+            "viewBox": "0 0 512 512",
+          }
+        }
+        className="FieldWrapper__dropdownIcon"
+      >
+        <svg
+          className="FieldWrapper__dropdownIcon"
+          fill="currentColor"
+          height="1em"
+          stroke="currentColor"
+          strokeWidth="0"
+          style={
+            Object {
+              "color": undefined,
+            }
+          }
+          viewBox="0 0 512 512"
+          width="1em"
+          xmlns="http://www.w3.org/2000/svg"
+        >
+          <path
+            d="M128 320l128-128 128 128z"
+            key="0"
+          />
+        </svg>
+      </IconBase>
+    </IoMdArrowDropup>
+  </div>
+</FieldWrapper>
+`;
+
+exports[`FieldWrapper should render correctly 1`] = `
+<FieldWrapper
+  clearLabel=""
+  disabled={false}
+  isArrowUp={false}
+  isFocused={false}
+  onClear={null}
+  showArrow={false}
+  showClearButton={false}
+>
+  <div
+    className="FieldWrapper"
+    disabled={false}
+  >
+    <div
+      className="FieldWrapper__content"
+    >
+      some children
+    </div>
+  </div>
+</FieldWrapper>
+`;
diff --git a/...components/LocationAutocomplete/__tests__/__snapshots__/LocationAutocomplete.spec.js.snap b/...components/LocationAutocomplete/__tests__/__snapshots__/LocationAutocomplete.spec.js.snap
@@ -270,7 +270,7 @@ exports[`<LocationAutocomplete/> that renders a location search field should pas
             className="AutosuggestDeprecated__field"
             clearLabel=""
             disabled={false}
-            isArrowDropUp={false}
+            isArrowUp={false}
             isFocused={true}
             onClear={[Function]}
             onClick={[Function]}
@@ -688,7 +688,7 @@ exports[`<LocationAutocomplete/> that renders a location search field should ren
             className="AutosuggestDeprecated__field"
             clearLabel=""
             disabled={false}
-            isArrowDropUp={false}
+            isArrowUp={false}
             isFocused={false}
             onClear={[Function]}
             onClick={[Function]}

diff --git a/...lector/LocationSelectorDialog/__tests__/__snapshots__/LocationSelectorDialog.spec.js.snap b/...lector/LocationSelectorDialog/__tests__/__snapshots__/LocationSelectorDialog.spec.js.snap
@@ -165,7 +165,7 @@ exports[`LocationSelectorDialog component should render correctly 1`] = `
                 className="AutosuggestDeprecated__field"
                 clearLabel=""
                 disabled={false}
-                isArrowDropUp={false}
+                isArrowUp={false}
                 isFocused={true}
                 onClear={[Function]}
                 onClick={[Function]}

diff --git a/src/components/LocationSelector/__tests__/__snapshots__/LocationSelector.spec.js.snap b/src/components/LocationSelector/__tests__/__snapshots__/LocationSelector.spec.js.snap
@@ -62,7 +62,7 @@ exports[`LocationSelector component should render LocationSelector properly when
       className="LocationSelector__mainTextButtonWrapper"
       clearLabel="Clear"
       disabled={false}
-      isArrowDropUp={false}
+      isArrowUp={false}
       isFocused={true}
       onClear={[MockFunction]}
       onClick={[Function]}
@@ -478,7 +478,7 @@ exports[`LocationSelector component should render LocationSelector propertly whe
       className="LocationSelector__mainTextButtonWrapper"
       clearLabel="Clear"
       disabled={false}
-      isArrowDropUp={false}
+      isArrowUp={false}
       isFocused={false}
       onClear={[MockFunction]}
       onClick={[Function]}

diff --git a/src/components/SelectComponents/Autosuggest/__tests__/__snapshots__/Autosuggest.spec.js.snap b/src/components/SelectComponents/Autosuggest/__tests__/__snapshots__/Autosuggest.spec.js.snap
@@ -82,7 +82,7 @@ exports[`Autosuggest rendering should initially render empty component correctly
             className="SelectBase__field"
             clearLabel=""
             disabled={false}
-            isArrowDropUp={false}
+            isArrowUp={false}
             isFocused={false}
             onClear={[Function]}
             onClick={[Function]}
@@ -224,7 +224,7 @@ exports[`Autosuggest rendering should initially render focused component correct
             className="SelectBase__field"
             clearLabel=""
             disabled={false}
-            isArrowDropUp={true}
+            isArrowUp={true}
             isFocused={true}
             onClear={[Function]}
             onClick={[Function]}
@@ -421,7 +421,7 @@ exports[`Autosuggest rendering should initially render focused component with su
             className="SelectBase__field"
             clearLabel=""
             disabled={false}
-            isArrowDropUp={true}
+            isArrowUp={true}
             isFocused={true}
             onClear={[Function]}
             onClick={[Function]}
@@ -1069,7 +1069,7 @@ exports[`Autosuggest rendering should render component with suggestions 1`] = `
             className="SelectBase__field"
             clearLabel=""
             disabled={false}
-            isArrowDropUp={true}
+            isArrowUp={true}
             isFocused={true}
             onClear={[Function]}
             onClick={[Function]}
@@ -1703,7 +1703,7 @@ exports[`Autosuggest rendering should render isLoading state 1`] = `
             className="SelectBase__field"
             clearLabel=""
             disabled={false}
-            isArrowDropUp={true}
+            isArrowUp={true}
             isFocused={true}
             onClear={[Function]}
             onClick={[Function]}
@@ -2103,7 +2103,7 @@ exports[`Autosuggest rendering should show "no suggestions" placeholder only if
             className="SelectBase__field"
             clearLabel=""
             disabled={false}
-            isArrowDropUp={true}
+            isArrowUp={true}
             isFocused={true}
             onClear={[Function]}
             onClick={[Function]}
@@ -2261,7 +2261,7 @@ exports[`Autosuggest rendering should show "no suggestions" placeholder only if
             className="SelectBase__field"
             clearLabel=""
             disabled={false}
-            isArrowDropUp={true}
+            isArrowUp={true}
             isFocused={true}
             onClear={[Function]}
             onClick={[Function]}
@@ -2471,7 +2471,7 @@ exports[`Autosuggest rendering should show "no suggestions" placeholder only if
             className="SelectBase__field"
             clearLabel=""
             disabled={false}
-            isArrowDropUp={true}
+            isArrowUp={true}
             isFocused={true}
             onClear={[Function]}
             onClick={[Function]}

diff --git a/...ponents/SelectComponents/ComboboxMulti/__tests__/__snapshots__/ComboboxMulti.spec.js.snap b/...ponents/SelectComponents/ComboboxMulti/__tests__/__snapshots__/ComboboxMulti.spec.js.snap
@@ -143,7 +143,7 @@ exports[`ComboboxMulti rendering should initially render empty component correct
             className="SelectBase__field"
             clearLabel=""
             disabled={false}
-            isArrowDropUp={false}
+            isArrowUp={false}
             isFocused={false}
             onClear={[Function]}
             onClick={[Function]}
@@ -409,7 +409,7 @@ exports[`ComboboxMulti rendering should render all suggestions from the list 1`]
             className="SelectBase__field"
             clearLabel=""
             disabled={false}
-            isArrowDropUp={true}
+            isArrowUp={true}
             isFocused={true}
             onClear={[Function]}
             onClick={[Function]}