-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding an SCR section to the docs #2090
base: main
Are you sure you want to change the base?
Conversation
Here is a little proof this works in HTML: And you can see proof this works in PDF here: https://github.com/terrapower/armi/actions/runs/13725317705?pr=2090 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I know you have to wait to merge, but you have the green check for when you need it.
Update: haha, I submitted this review before checking CI. I'm assuming you're just troubleshooting the token.
What is the change? Why is it being made?
Here I add a new process to ARMI. Instead of just a random "release notes" section, every ARMI PR will come with an SCR. This is part of the on-going quality work in ARMI.
Notes:
0.5.1
.0.5.rst
release notes yet. I will do that before I merge this.)SCR Information
Change Type: docs
One-Sentence Description: ARMI now has an automated "SCR" section, instead of a manual "Release Notes" section that has to be tweaked in code.
One-line Impact on Requirements: NA
Checklist
doc
folder.pyproject.toml
.