Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix single-card nightly and perf pipelines breaking because huggingface-hub got rid of cached_download #14076

Closed
tt-rkim opened this issue Oct 22, 2024 · 1 comment
Closed

Fix single-card nightly and perf pipelines breaking because huggingface-hub got rid of cached_download #14076

tt-rkim opened this issue Oct 22, 2024 · 1 comment
Assignees
@tt-rkim
Labels
ci-bug bugs found in CI dependencies infra-ci infrastructure and/or CI changes P0

Comments

@tt-rkim
Copy link
Collaborator

tt-rkim commented Oct 22, 2024

The diffusers package at the version we're using depends on >=0.10.0 of huggingface-hub: https://github.com/huggingface/diffusers/blob/v0.12.1/setup.py#L89

But looks like they got rid of a needed function in the newer v0.26 release.

I'm going to try pinning huggingface-hub to a working version for now, and then file an issue to upgrade later.

https://github.com/tenstorrent/tt-metal/actions/runs/11449999532/job/31857698547#step:10:194
@tt-rkim tt-rkim added infra-ci infrastructure and/or CI changes P0 ci-bug bugs found in CI dependencies labels Oct 22, 2024
@tt-rkim tt-rkim self-assigned this Oct 22, 2024
tt-rkim added a commit that referenced this issue Oct 22, 2024
@tt-rkim
#14076: Pin huggingface-hub to 0.25.2 to fix pipelines
b1619d2
@tt-rkim tt-rkim mentioned this issue Oct 22, 2024
Merged
5 tasks
tt-rkim added a commit that referenced this issue Oct 22, 2024
@tt-rkim
#14076: Add myself and Michael as codeowners of requirements.txt, esp…
e45692c 
…ecially one in tt_metal
tt-rkim added a commit that referenced this issue Oct 22, 2024
@tt-rkim
#14076: Pin huggingface-hub to 0.25.2 to fix pipelines
de5ceb7
tt-rkim added a commit that referenced this issue Oct 22, 2024
@tt-rkim
#14076: Add myself and Michael as codeowners of requirements.txt, esp…
7b7435e 
…ecially one in tt_metal
tt-rkim added a commit that referenced this issue Oct 22, 2024
@tt-rkim
#14076: Pin huggingface-hub to 0.25.2 to fix perf pipelines (#14094)
3025af2 
* #14076: Pin huggingface-hub to 0.25.2 to fix pipelines

* #14076: Add myself and Michael as codeowners of requirements.txt, especially one in tt_metal
@tt-rkim tt-rkim closed this as completed Oct 22, 2024
@tt-rkim
Copy link
Collaborator Author

tt-rkim commented Oct 22, 2024

huggingface/huggingface_hub#2617

for more info

ct-clmsn pushed a commit to ct-clmsn/tt-metal that referenced this issue Nov 12, 2024
@tt-rkim
tenstorrent#14076: Pin huggingface-hub to 0.25.2 to fix perf pipelines (
add5e83 
tenstorrent#14094)

* tenstorrent#14076: Pin huggingface-hub to 0.25.2 to fix pipelines

* tenstorrent#14076: Add myself and Michael as codeowners of requirements.txt, especially one in tt_metal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tt-rkim tt-rkim

Labels
ci-bug bugs found in CI dependencies infra-ci infrastructure and/or CI changes P0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tt-rkim