Update Result API container env #2622
Conversation
Earlier Result API container env was not getting updated if any fields in Result API properties gets updated, now this patch updates Result API container env with updated Result API properties Signed-off-by: Shiv Verma <[email protected]>
tekton-robot
added
the
release-note
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
size/L
|
The following is the coverage report on the affected files.
|
|
This issue #2600 is also a similar problem, where certain properties |
| types := reflect.TypeOf(p) | ||
| prop := make(map[string]string) | ||
|
|
||
| applyLokiStackConfig(prop, s.LokiStackProperties) |
There was a problem hiding this comment.
what happens if an error happens on applyLokiStackConfig
| @@ -271,6 +272,119 @@ func updateApiConfig(s v1alpha1.TektonResultSpec) mf.Transformer { | |||
| } | |||
| } | |||
|
|
|||
| // update the api container envs | |||
There was a problem hiding this comment.
can you add more description here to show up that it also aupdates lockistack
that it is restricted for deployment and container with specific anmes
Earlier Result API container env was not getting updated if any fields in Result API properties gets updated, now this patch updates Result API container env with updated Result API properties
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make test lintbefore submitting a PRSee the contribution guide for more details.
Release Notes
-->