Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After tagging, exporting and updating component i can't see changes #2796

Closed
nevolgograd opened this issue Jul 3, 2020 · 7 comments · Fixed by #2799
Closed

After tagging, exporting and updating component i can't see changes #2796

nevolgograd opened this issue Jul 3, 2020 · 7 comments · Fixed by #2799
Assignees
Labels

Comments

@nevolgograd
Copy link

nevolgograd commented Jul 3, 2020

Describe the bug

After tagging, exporting and updating component i can't see changes.
Version in my package.json is updated, code in /node_modules/@bit/scalez.savvy-ui.svg/svg.ts is updated ,but code in /node_modules/@bit/scalez.savvy-ui.svg/dist don't.

I was updating that component not for the first time: tag, export, install as always. Haven’t touched config, also.
Here's my file, it's also updated here - https://bit.dev/scalez/savvy-ui/svg/~code
I was adding instagram icon in last update, and now i can't import it.

Besides that, all my components are in "Generating preview" state. Playground is not loading and I can’t try import icon even there.

Steps to Reproduce

  1. npm i @bit/scalez.savvy-ui.svg
  2. import { instagram } from '@bit/scalez.savvy-ui.svg'
  3. ...
  4. Module '"../../../../../node_modules/@bit/scalez.savvy-ui.svg/dist/svg"' has no exported member 'instagram'.

Expected Behavior

Module HAS exported member 'instagram'

Specifications

  • Bit version: 14.8.4
  • Node version: 12.16.1
  • npm version: 6.14.4
  • Platform: Macos
  • Bit compiler (include version): compilers/react-typescript/@3.1.52
  • Bit tester (include version): -

Additional context

I've tried to update component once again, tried to delete node_modules and package.json, but it not helped. Looks like the issue related to compiler or something.

@davidfirst
Copy link
Member

davidfirst commented Jul 3, 2020

@nevolgograd , I suspect this is a regression of the last release. can you please try to downgrade to version 14.7.6 and see if gets resolved?

@nevolgograd
Copy link
Author

@davidfirst it happened on 14.8.0, i thought bit update will do the thing, but no.

@nevolgograd
Copy link
Author

@davidfirst you right, it worked! Thanks!
But this is weird, i was successfully updating other components with 14.8.0, why did it break?

@davidfirst
Copy link
Member

davidfirst commented Jul 3, 2020

@nevolgograd , that's what I'm trying to find out. Could you please send me your .bitmap and package.json files? (you can send to [email protected]).

Also, just to make sure, it didn't work with 14.8.0, only with 14.7.6 right?

@nevolgograd
Copy link
Author

@davidfirst yep, only with 14.7.6

@davidfirst
Copy link
Member

davidfirst commented Jul 4, 2020

Thanks @nevolgograd , I got the files and I was able to reproduce the issue. I fixed it in the PR above.

The issue was not with the 'bit build' but with 'bit tag' that triggers the build process.
Because this specific compiler in its latest versions saves extensions data into the model, it was confused to be a new component and not legacy, as a result, the legacy build process wasn't triggered only the new one (Harmony), which has a different build mechanism.

@GiladShoham , please make sure to release a new version before the deployment on Sunday. This is a critical fix.

@davidfirst davidfirst self-assigned this Jul 4, 2020
davidfirst added a commit that referenced this issue Jul 4, 2020
@GiladShoham
Copy link
Member

Thanks @davidfirst I'll make sure to release a new version tomorrow morning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants