-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for ECMA402 PR833 Allow locale based ignorePunctuation default #3922
Conversation
please add "awaiting specification" label |
This will be discuss in Oct TG2 first and bring to TC39 on 2023-Nov |
ECMA402 PR833 reach consensus in TC39 around 2024-02-06 11:25am PST tc39/ecma402#833 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Assertion messages should be updated to use the correct language names.
test/intl402/Collator/prototype/resolvedOptions/ignorePunctuation-default.js
Outdated
Show resolved
Hide resolved
test/intl402/Collator/prototype/resolvedOptions/ignorePunctuation-default.js
Outdated
Show resolved
Hide resolved
@tc39/test262-maintainers: "awaiting specification" label can be removed and instead be replaced with "has consensus". |
PTAL and merge this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
…ion-default.js Co-authored-by: André Bargull <[email protected]>
…ion-default.js Co-authored-by: André Bargull <[email protected]>
ea3dc88
to
eb2a9d6
Compare
Test the default of Collator ignorePunctuation depens on locale not always false.
tc39/ecma402#833