Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intl: Add coverage for meaningful @@toStringTag values #2634

Merged
merged 6 commits into from
Jun 1, 2020
Merged

Intl: Add coverage for meaningful @@toStringTag values #2634

merged 6 commits into from
Jun 1, 2020

Conversation

shvaikalesh
Copy link
Member

@shvaikalesh shvaikalesh force-pushed the intl402-symbol-tostringtag branch from 93baee1 to c84fed9 Compare May 21, 2020 13:50
@leobalter leobalter self-assigned this May 21, 2020
leobalter
leobalter suggested changes May 21, 2020
View reviewed changes
Copy link
Member

@leobalter leobalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one thing else I left in the comments for the coverage.

Let's wait until the PR is accepted before merging.

@shvaikalesh shvaikalesh mentioned this pull request May 21, 2020
Merged
@shvaikalesh shvaikalesh force-pushed the intl402-symbol-tostringtag branch from c84fed9 to 74a7951 Compare May 26, 2020 20:50
@leobalter leobalter added ECMA-402 ECMA-402 related PRs and removed awaiting specification labels Jun 1, 2020
@leobalter leobalter merged commit ef12a8b into tc39:master Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leobalter leobalter leobalter approved these changes

Assignees

@leobalter leobalter

Labels
ECMA-402 ECMA-402 related PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shvaikalesh @leobalter