Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: Cleanup CompareStrings #680

Merged
merged 6 commits into from
Jun 16, 2022
Merged

Editorial: Cleanup CompareStrings #680

merged 6 commits into from
Jun 16, 2022

Conversation

gibson042
Copy link
Contributor

@gibson042 gibson042 requested a review from ryzokuken April 27, 2022 23:00
@gibson042
Copy link
Contributor Author

@ryzokuken Ping.

ryzokuken
ryzokuken approved these changes Jun 16, 2022
View reviewed changes
Copy link
Member

@ryzokuken ryzokuken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a pending review, forgot to actually post it and you fixed it already. Feels unfair, but thanks! LGTM 😇

@ryzokuken ryzokuken merged commit 56a23ec into tc39:master Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryzokuken ryzokuken ryzokuken approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gibson042 @ryzokuken