Normative: Apply recommended updates for BCP 47 Locale Identifiers #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
littledan
approved these changes
Mar 18, 2019
| @@ -51,7 +50,7 @@ <h1>IsStructurallyValidLanguageTag ( _locale_ )</h1> | |||
| </ul> | |||
|
|
|||
| <p> | |||
| The abstract operation returns true if _locale_ can be generated from the ABNF grammar in section 3.2 of the Unicode Technical Standard 35, or successor, starting with unicode_locale_id, and does not contain duplicate variant or singleton subtags (other than as a private use subtag). It returns false otherwise. Terminal value characters in the grammar are interpreted as the Unicode equivalents of the ASCII octet values given. | |||
| The abstract operation returns true if _locale_ can be generated from the EBNF grammar in section 3.2 of the Unicode Technical Standard 35, or successor, starting with unicode_locale_id, and does not contain duplicate variant or singleton subtags (other than as a private use subtag). It returns false otherwise. Terminal value characters in the grammar are interpreted as the Unicode equivalents of the ASCII octet values given. | |||
There was a problem hiding this comment.
I guess ABNF or EBNF both work here, as Unicode defines both grammars for some reason.
There was a problem hiding this comment.
NO, we should surely switch to EBNF because Mark Davis is deleting ABNF from UTS35 now. The update will be pushed out very soon. See http://unicode.org/repos/cldr/trunk/specs/ldml/tr35.html#Unicode_Language_and_Locale_Identifiers
the ABNF was very buggy (see http://unicode.org/cldr/trac/ticket/11746 and more)
The EBNF on that latest version still have some minor problems and I am reviewing for Mark Davis now. He will fix them shortly.
|
LGTM |
FrankYFTang
approved these changes
Mar 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #330
cc @anba @sffc @FrankYFTang
This is a tentative to update the immediate parts of #330, please let me know WDYT?