Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECMA-402 should allow numeric-offset host time zones #683

Closed
gibson042 opened this issue Nov 14, 2021 · 13 comments · Fixed by #788
Closed

ECMA-402 should allow numeric-offset host time zones #683

gibson042 opened this issue Nov 14, 2021 · 13 comments · Fixed by #788
Assignees
Labels
c: datetime Component: dates, times, timezones
Milestone

Comments

@gibson042
Copy link
Contributor

gibson042 commented Nov 14, 2021

Among other things, this would remove the need for ECMA-402 Temporal to override ECMA-262 DefaultTimeZone.

@ptomato
Copy link
Contributor

ptomato commented Nov 19, 2021

Should this be a discussion over at tc39/ecma402 instead?

@gibson042
Copy link
Contributor Author

I'm considering it a change that would be part of Temporal, but if it makes more sense to discuss there then that's fine.

@ptomato
Copy link
Contributor

ptomato commented May 10, 2022

I think all the necessary changes on the Temporal side are in tc39/proposal-temporal#2171.

In ECMA-402 they would then delete their override of DefaultTimeZone and ensure that all of its callers are prepared to deal with a numeric-offset time zone. I think that further discussion should be had over there, because it doesn't affect Temporal.

@gibson042
Copy link
Contributor Author

gibson042 commented Oct 18, 2022

Affirmed by tc39/ecma262#2781 : tc39/ecma262#2781 (comment)

@sffc
Copy link
Contributor

sffc commented Dec 8, 2022

For example:

new Intl.DateTimeFormat("en", { timeZone: "+01:00" })

@sffc sffc added this to the ES 2023 milestone Dec 8, 2022
@sffc sffc added s: help wanted Status: help wanted; needs proposal champion c: datetime Component: dates, times, timezones labels Dec 8, 2022
@ptomato

This comment was marked as resolved.

@sffc
Copy link
Contributor

sffc commented Dec 8, 2022

TG2 discussion: https://github.com/tc39/ecma402/blob/master/meetings/notes-2022-12-08.md#ecma-402-should-allow-numeric-offset-host-time-zones-683

Conclusion: Yes, move forward with a PR for this. @gibson042 kindly volunteered to make the PR.

@justingrant
Copy link
Contributor

justingrant commented Jan 8, 2023

TG2 discussion: https://github.com/tc39/ecma402/blob/master/meetings/notes-2022-12-08.md#ecma-402-should-allow-numeric-offset-host-time-zones-683

Conclusion: Yes, move forward with a PR for this. @gibson042 kindly volunteered to make the PR.

@gibson042 - Is there a PR? Asking because a PR to resolve #741 may end up touching the same parts of the spec, so we should coordinate.

@ptomato
Copy link
Contributor

ptomato commented Apr 11, 2023

Note, completing this issue should also remove the "If IsTimeZoneOffsetString(timeZone) is true, throw a RangeError exception." step from Temporal.ZonedDateTime.prototype.toLocaleString.

@justingrant
Copy link
Contributor

Note, completing this issue should also remove the "If IsTimeZoneOffsetString(timeZone) is true, throw a RangeError exception." step from Temporal.ZonedDateTime.prototype.toLocaleString.

It's possible that future PRs (I'm working on one now!) may introduce other blocks of offset strings, so doing a full search for If IsTimeZoneOffsetString in intl.html in the Temporal spec is probably a good idea.

@justingrant
Copy link
Contributor

@gibson042 - are you still on track to have a PR for this issue available for this week's TG2 meeting?

@justingrant justingrant removed the s: help wanted Status: help wanted; needs proposal champion label Jun 1, 2023
gibson042 added a commit to gibson042/ecma402 that referenced this issue Jun 1, 2023
gibson042 added a commit to gibson042/ecma402 that referenced this issue Jun 1, 2023
@gibson042
Copy link
Contributor Author

pull request: #788

@FrankYFTang
Copy link
Contributor

I need to investigate the cost to make the dft.resolvedOptions().timeZone return "+01:00"

gibson042 added a commit to gibson042/ecma402 that referenced this issue Sep 7, 2023
ben-allen pushed a commit to ben-allen/ecma402 that referenced this issue Oct 12, 2023
@sffc sffc moved this to Previously Discussed in ECMA-402 Meeting Topics Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: datetime Component: dates, times, timezones
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants