Adding explicit number conversion to %TypedArray%.prototype.sort #1000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you merge this into a single step:
for consistency with the SortCompare algorithm in 22.1.3.25.1? Thanks! |
ljharb
requested changes
Sep 13, 2017
spec.html
Outdated
| @@ -33221,7 +33221,7 @@ | |||
| <emu-alg> | |||
| 1. Assert: Both Type(_x_) and Type(_y_) is Number. | |||
| 1. If _comparefn_ is not *undefined*, then | |||
| 1. Let _v_ be ? Call(_comparefn_, *undefined*, « _x_, _y_ »). | |||
| 1. Let _v_ be ToNumber(? Call(_comparefn_, *undefined*, « _x_, _y_ »)). | |||
There was a problem hiding this comment.
the ToNumber needs a ? prefix as well, since it can throw
ljharb
approved these changes
Sep 13, 2017
ljharb
added
the
normative change
|
Does this need consensus? |
|
shouldn't need consensus. It's pretty clearly a bug that Array sort has a ToNumber but TypedArray sort does not. |
|
Yep, seems like a bug to me (and a bad one, at that). Thanks! |
|
@natashenka Congratulations on your first commit to ECMA262! 👌👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarifying that conversion to a number from comparefn should occur before the detachment check. This ambiguity led to this security problem: https://bugs.chromium.org/p/project-zero/issues/detail?id=983