Fix DPI scaling on 'offset' parameter for points. #2186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tallytalwar
approved these changes
Sep 14, 2020
|
Nice! So what was the bug? Offset was assumed to be pixel scale ==1? |
|
Yeah essentially. Labels drawn using the "Points" style were missing the step where pixel scale is applied to "offset". The "Text" style was applying pixel scale correctly, so the problem became very clear when multiple "Points" and "Text" meshes were drawn together. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2177
The change that actually addresses this issue is 6a6a8da, the rest is just cleanup and convenience functionality that happened while I was debugging.