Convert to netstandard2.0 and upgrade to use .Net CLI #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, think that might be as far as I can go now without feedback/input (apologies for the other closed pull requests) . It looks like AppVeyor is looking for a Release folder that will now be different for netstandard/netcore etc. Is this something you can configure on your pipeline? Thanks, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I have converted the core library to support netstandard2.0 and net451 (and tested against both). I have also resolved a few issues from my previous pull requests (was easier to just start fresh).
I have also upgraded the Samples and Test projects and the solution file to use .Net Core and everything now supports development from the .NET CLI along with Visual Studio.
Looking forward to your feedback.
Thanks,
Steven