Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[error] Warn Linux users about manylinux2014 build on startup #6416

Merged
merged 3 commits into from
Oct 24, 2022

Conversation

feisuzhu
Copy link
Contributor

Issue: #

Brief Summary

@feisuzhu feisuzhu requested a review from ailzhang October 24, 2022 07:45
@netlify
Copy link

netlify bot commented Oct 24, 2022

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit d5839b4
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/635642d9fd588900083113b7
😎 Deploy Preview https://deploy-preview-6416--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only had a nit about when to show this error message. Thanks a ton!

@feisuzhu feisuzhu merged commit 8051b7f into taichi-dev:master Oct 24, 2022
@feisuzhu feisuzhu deleted the feat/vulkan-warning branch October 24, 2022 09:37
@jim19930609 jim19930609 added this to the v1.2.0 milestone Oct 25, 2022
jim19930609 pushed a commit to jim19930609/taichi that referenced this pull request Oct 25, 2022
…-dev#6416)

Issue: #

### Brief Summary

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
jim19930609 pushed a commit to jim19930609/taichi that referenced this pull request Oct 25, 2022
…i-dev#6416)

Issue: #

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants