Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lang] MatrixType bug fix: Fix array indexing with MatrixType-index #6323

Merged
merged 10 commits into from
Oct 17, 2022

Conversation

jim19930609
Copy link
Contributor

Issue: #5819

Brief Summary

Taichi supports indexing field/ndarray/... using MatrixTyped index. For example:

x = ti.field(shape=(2, 4), ti.i32)

@ti.kernel
def test():
  base = ti.Vector([1, 1])
  x[base] = 100

After this PR, the above test case works under real_matrix and real_matrix_scalarize

@jim19930609 jim19930609 requested review from strongoier and ailzhang and removed request for strongoier October 14, 2022 05:28
@netlify
Copy link

netlify bot commented Oct 14, 2022

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit 6073ca5
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/634cfe852fb2e700082e9f69
😎 Deploy Preview https://deploy-preview-6323--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@strongoier strongoier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jim19930609 jim19930609 merged commit 1093f37 into taichi-dev:master Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants