[Vulkan] Add overflow detection on vulkan when debug=True #6279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsite-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
lin-hitonami
force-pushed
the
vulkan_overflow
branch
from
efd92f8 to
09db5a4
Compare
lin-hitonami
force-pushed
the
vulkan_overflow
branch
from
ee55caf to
972d6f2
Compare
for more information, see https://pre-commit.ci
lin-hitonami
force-pushed
the
vulkan_overflow
branch
from
713c3b4 to
0518b78
Compare
lin-hitonami
force-pushed
the
vulkan_overflow
branch
from
6d16d55 to
a2404be
Compare
for more information, see https://pre-commit.ci
lin-hitonami
force-pushed
the
vulkan_overflow
branch
from
e5f4f7b to
c8551cd
Compare
lin-hitonami
force-pushed
the
vulkan_overflow
branch
from
ba5c052 to
6f5dc9b
Compare
for more information, see https://pre-commit.ci
lin-hitonami
force-pushed
the
vulkan_overflow
branch
2 times, most recently
from
9c06042 to
8ee9427
Compare
lin-hitonami
force-pushed
the
vulkan_overflow
branch
from
068e6a2 to
e8ce27b
Compare
for more information, see https://pre-commit.ci
lin-hitonami
requested review from
ailzhang,
PENGUINLIONG,
k-ye,
jim19930609 and
yuanming-hu
ailzhang
approved these changes
Oct 13, 2022
It's possible but I'm afraid we can't use the backend-specific instructions if we lift these to CHI IR level... |
|
Don't merge yet. I've spotted a bug on smul |
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #5932
Brief Summary
Added overflow detection of addition, subtraction, multiplication and shift left operators on Vulkan.
Known bug: 64-bit multiplication overflow detection works on NVIDIA driver 510 with Vulkan version 1.3.194 but does not work on NVIDIA driver 470 with Vulkan version 1.2.175. See #6303
TODO: Support for OpenGL should be automatically available when the print support of OpenGL is available. Add OpenGL to the test at that time.