Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Remove unnecessary lower() in AotModuleBuilder::add #6068

Merged
merged 1 commit into from
Sep 16, 2022

Conversation

PGZXB
Copy link
Contributor

@PGZXB PGZXB commented Sep 15, 2022

Related issue = #4401
Run python run_tests.py --cpp --with-offline-cache failed, reported by https://github.com/taichi-dev/taichi/actions/runs/3055000542. Reason: Generate AST key ([1]) after lowering ([2]).

[1]

std::string kernel_key = get_hashed_offline_cache_key(&config, kernel);

[2]

if (!kernel->lowered() && Kernel::supports_lowering(kernel->arch)) {
kernel->lower(/*to_executable=*/!arch_uses_llvm(kernel->arch));
}

@netlify
Copy link

netlify bot commented Sep 15, 2022

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit 421b4fb
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/6322d320e0020d00088948fa
😎 Deploy Preview https://deploy-preview-6068--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@PGZXB PGZXB requested review from lin-hitonami and k-ye September 15, 2022 08:34
Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@ailzhang ailzhang merged commit 50c925b into taichi-dev:master Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants