Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] [test] Run C-API tests correctly on Windows #6038

Merged
merged 4 commits into from
Sep 13, 2022
Merged

[bug] [test] Run C-API tests correctly on Windows #6038

merged 4 commits into from
Sep 13, 2022

Conversation

PGZXB
Copy link
Contributor

@PGZXB PGZXB commented Sep 12, 2022

Related issue = #

Output all exes to build/

This PR moves it to bin, which is in the PATH and we can run taichi_cpp_tests everywhere.
--from #2515 (comment)

IMO, we should run cpp/capi tests by running python run_tests.py --cpp instead of launching taichi_cpp_tests(.exe) manually

@netlify
Copy link

netlify bot commented Sep 12, 2022 •
edited
Loading

✅ Deploy Preview for docsite-preview canceled.

Name Link
🔨 Latest commit 1943a61
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/631fc9c410f00e0008683083

@PGZXB PGZXB marked this pull request as draft September 12, 2022 09:22
@PGZXB PGZXB marked this pull request as ready for review September 12, 2022 10:07
ailzhang
ailzhang suggested changes Sep 12, 2022
View reviewed changes
Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Let's make sure it's not accidentally disabled before merging ;)

ailzhang
ailzhang approved these changes Sep 13, 2022
View reviewed changes
Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ailzhang ailzhang merged commit e22a2a3 into taichi-dev:master Sep 13, 2022
@PGZXB PGZXB mentioned this pull request Oct 3, 2022
Merged
PGZXB added a commit that referenced this pull request Oct 8, 2022
@PGZXB
[doc] Update document about building and running Taichi C++ tests (#6228
cfa59c6 
)

Issue: #6038 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ailzhang ailzhang ailzhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PGZXB @ailzhang