[bug] [test] Fix patch_os_environ_helper #6017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsite-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR = #6002
In #6002,
test_init_argandtest_init_archfails on Windows. The failure is caused by reading outdated offline cache format. However, we have set offline cache to off and set the offline cache directory to a new directory in the environment variables inrun_tests.py, so this should not happen. Then, I discovered that functionpatch_os_environ_helperwhich intends to remove only a few specified environment variables (excludes) accidentally removes all the environment variables, and replaced them withcustom_environ. This PR fixes the bug and lets it work as expected.