Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[autodiff] Avoid initializing Field with None #6007

Merged
merged 2 commits into from
Sep 7, 2022
Merged

[autodiff] Avoid initializing Field with None #6007

merged 2 commits into from
Sep 7, 2022

Conversation

strongoier
Copy link
Contributor

When x_grad or x_dual is None, they should not be used to initialize the Field class.

@strongoier strongoier requested a review from erizmr September 7, 2022 09:38
erizmr
erizmr approved these changes Sep 7, 2022
View reviewed changes
Copy link
Contributor

@erizmr erizmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@strongoier strongoier merged commit 7619efc into taichi-dev:master Sep 7, 2022
@strongoier strongoier deleted the fix-none-field branch September 7, 2022 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erizmr erizmr erizmr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@strongoier @erizmr