[cuda] Clear cuda context after init #5891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsite-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
for more information, see https://pre-commit.ci
turbo0628
changed the title
turbo0628
changed the title
turbo0628
changed the title
for more information, see https://pre-commit.ci
ailzhang
reviewed
Aug 30, 2022
turbo0628
force-pushed
the
pop_cuda_context
branch
from
e08f302 to
585538e
Compare
ailzhang
pushed a commit
to ailzhang/taichi
that referenced
this pull request
Sep 5, 2022
session Main goal is to get rid of the to-do in comment as it's fixed taichi-dev#5891
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5502
Briefing:
Currently, Taichi setup a CUDAContext after
ti.init. However, this might cause problems with third-party frameworks, including PyTorch and Numba.This PR pop out the CUDAContext at the end of
ti.init, and push the context back when needed.