[vulkan] Less sync overhead for GGUI & Device API Examples #5880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
✅ Deploy Preview for docsite-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
bobcao3
requested review from
PENGUINLIONG,
ailzhang and
k-ye
and removed request for
PENGUINLIONG
bobcao3
changed the title
for more information, see https://pre-commit.ci
bobcao3
changed the title
bobcao3
changed the title
bobcao3
force-pushed
the
bobcao3/rhi_examples
branch
from
f826f43 to
a0ca3da
Compare
bobcao3
force-pushed
the
bobcao3/rhi_examples
branch
from
a0ca3da to
69eb34c
Compare
bobcao3
force-pushed
the
bobcao3/rhi_examples
branch
from
106862b to
4b22098
Compare
|
/rerun |
3 similar comments
|
/rerun |
|
/rerun |
|
/rerun |
|
/rerun |
|
Thanks! fyi reviewing in progress as this is large... will try to get it done by EOW. |
|
thank you! |
Morcki
pushed a commit
that referenced
this pull request
Sep 1, 2022
Morcki
reviewed
Sep 1, 2022
| mat4 model = mat4(1.0) * (1.0 - ubo.has_attribute) + model_tmp * ubo.has_attribute; | ||
|
|
||
| gl_Position = ubo.scene.projection * ubo.scene.view * model * vec4(in_position, 1.0); | ||
| gl_Position = ubo.scene.projection * ubo.scene.view * vec4(in_position, 1.0); |
There was a problem hiding this comment.
Why should we remove the implementation of mesh instancing in mesh shader?
| @@ -265,7 +265,7 @@ def render(): | |||
| render() | |||
| write_temp_image(window) | |||
| render() | |||
| verify_image(window, 'test_set_image') | |||
| verify_image(window, 'test_set_image', 0.5) | |||
There was a problem hiding this comment.
Why we should change tolerance from 0.1 to 0.5?
This was referenced Sep 1, 2022
Merged
strongoier
pushed a commit
that referenced
this pull request
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains #5749
Since there's a bunch of fixes needed to pass CI, and there's also a bunch of related device API fixes. I didn't have enough time to separate these two change-sets, sorry for that for all the reviewers.