Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lang] Allow implicit conversion of integer types in if conditions #5763

Merged
merged 7 commits into from
Aug 23, 2022

Conversation

re-xyr
Copy link
Contributor

@re-xyr re-xyr commented Aug 15, 2022

Related issue = fixes #5675

@netlify
Copy link

netlify bot commented Aug 15, 2022

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit 1cb05db
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/6304469aed462a0009be2e0d
😎 Deploy Preview https://deploy-preview-5763--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@re-xyr re-xyr force-pushed the fix-i64-condition-3rd branch from e887a19 to 88e9edd Compare August 15, 2022 03:53
@re-xyr re-xyr changed the title [Lang] Fix boolean literals being given default_ip instead of i32 [Lang] Allow implicit conversion of integer types in if conditions Aug 15, 2022
Copy link
Contributor

@strongoier strongoier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@strongoier strongoier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's pass CI.

@strongoier strongoier merged commit 1390bcc into taichi-dev:master Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

default_ip=ti.i64 doesn't work with if
2 participants