[gui] GGUI scene APIs are broken #5658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsite-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
for more information, see https://pre-commit.ci
|
BTW when there is no point light, scene rendering doesn't work. |
PENGUINLIONG
changed the title
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
ailzhang
approved these changes
Aug 7, 2022
There was a problem hiding this comment.
Thanks! @PENGUINLIONG would you mind sending another PR against rc-v1.1.0 branch as well?
PENGUINLIONG
added a commit
to PENGUINLIONG/taichi
that referenced
this pull request
Aug 8, 2022
* GGUI scene ambient_light is broken * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fixed point light * Ensure the allocation of light source SSBO * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update canvas.py * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
ailzhang
pushed a commit
that referenced
this pull request
Aug 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ambient_lightexample is broken:which gives:
point_lighthas a similar issue.Also note that if a scene doesn't have any lighting except for the ambient light, no lighting SSBO will be allocated and
Canvas.scenewill crash attempting to map this SSBO. Tried not to map whenpoint_lights.size() == 0but it doesn't work. So workaround atm.