Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] Allow ti.types.ndarray annotation for ti.func #5600

Closed
wants to merge 1 commit into from
Closed

[bug] Allow ti.types.ndarray annotation for ti.func #5600

wants to merge 1 commit into from

Conversation

jim19930609
Copy link
Contributor

@jim19930609 jim19930609 commented Aug 2, 2022 •
edited
Loading

Related issue = #

@netlify
Copy link

netlify bot commented Aug 2, 2022 •
edited
Loading

✅ Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit fe5fe31
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/62e8bdd0335c7a000a6ee2b7
😎 Deploy Preview https://deploy-preview-5600--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@jim19930609 jim19930609 changed the title Allow ti.types.ndarray annotation for ti.func [bug] Allow ti.types.ndarray annotation for ti.func Aug 2, 2022
ailzhang
ailzhang approved these changes Aug 3, 2022
View reviewed changes
Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add a test? ;)

strongoier
strongoier reviewed Aug 3, 2022
View reviewed changes
Copy link
Contributor

@strongoier strongoier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm it may cause mismatch between the type annotation and the actual function. The ndarray annotation can have parameters, which is not equivalent to a template.

@jim19930609 jim19930609 closed this Aug 3, 2022
@jim19930609
Copy link
Contributor Author

Better fix the warning message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strongoier strongoier strongoier left review comments

@ailzhang ailzhang ailzhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jim19930609 @strongoier @ailzhang