Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[llvm] [aot] Add LLVM to CAPI part 1: Implemented capi::LlvmRuntime class #5393

Merged
merged 5 commits into from
Jul 13, 2022

Conversation

jim19930609
Copy link
Contributor

@jim19930609 jim19930609 commented Jul 12, 2022

Related issue = #4800

OffloadedTask is one of the dependent for LlvmOfflineCache. This class used to be declared in codegen_llvm.h, which essentially pollutes llvm_offline_cache.h since the entire codegen_llvm.h has to be included (together with all the sub-dependencies).

Added a new file taichi/codegen/llvm/llvm_compiled_data.h to store OffloadedTask and LLVMCompiledData, so as to purify the dependencies for llvm_offline_cache.h.

@netlify
Copy link

netlify bot commented Jul 12, 2022

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit 0337c05
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/62cd3ef4b11bab00092bfb0a
😎 Deploy Preview https://deploy-preview-5393--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@jim19930609 jim19930609 requested a review from PENGUINLIONG July 12, 2022 08:13
@PENGUINLIONG
Copy link
Member

BTW, I just noticed that llvm_offline_cache.h is not guarded by TI_WITH_LLVM and some build configs fail to compile.

@jim19930609
Copy link
Contributor Author

BTW, I just noticed that llvm_offline_cache.h is not guarded by TI_WITH_LLVM and some build configs fail to compile.

Ah my bad, thanks!

Copy link
Contributor

@lin-hitonami lin-hitonami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jim19930609 jim19930609 merged commit c40e19a into taichi-dev:master Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants