-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[llvm] [aot] Add LLVM to CAPI part 1: Implemented capi::LlvmRuntime class #5393
Conversation
✅ Deploy Preview for docsite-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
BTW, I just noticed that |
Ah my bad, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Related issue = #4800
OffloadedTask is one of the dependent for LlvmOfflineCache. This class used to be declared in
codegen_llvm.h
, which essentially pollutesllvm_offline_cache.h
since the entirecodegen_llvm.h
has to be included (together with all the sub-dependencies).Added a new file
taichi/codegen/llvm/llvm_compiled_data.h
to store OffloadedTask and LLVMCompiledData, so as to purify the dependencies forllvm_offline_cache.h
.