Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cuda] [type] Refine SNode with quant 6/n: Support __ldg for loading QuantFixedType and QuantFloatType #5374

Merged
merged 7 commits into from
Jul 11, 2022

Conversation

strongoier
Copy link
Contributor

@strongoier strongoier commented Jul 8, 2022

Related issue = #4857, #3382

This PR makes loading read-only QuantFixedType/QuantFloatType as optimized as QuantIntType in the CUDA backend. Involved functions are refactored by the way to get things cleaner.

@netlify
Copy link

netlify bot commented Jul 8, 2022

Deploy Preview for docsite-preview canceled.

Name Link
🔨 Latest commit 40bf934
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/62c811fd6fe4a50008f9b5b7

@strongoier strongoier changed the title [cuda] [type] Refine SNode with quant 6/n: Support __ldg for loading QuantFixedType [cuda] [type] Refine SNode with quant 6/n: Support __ldg for loading QuantFixedType and QuantFloatType Jul 8, 2022
@strongoier strongoier requested review from ailzhang and k-ye July 11, 2022 02:58
Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@strongoier strongoier merged commit 3459901 into taichi-dev:master Jul 11, 2022
@strongoier strongoier deleted the quant-array-fixed branch July 11, 2022 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants