Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lang] [type] Refine SNode with quant 3/n: Turn bit_vectorize into an on/off switch #5331

Merged
merged 2 commits into from
Jul 5, 2022

Conversation

strongoier
Copy link
Contributor

Related issue = #4857

bit_vectorize is currently an ad-hoc configuration function specifying how many bits are vectorized together, which leads to confusing API explanations like bit_vectorize(1) means off while bit_vectorize(32) means on. As the vectorization unit is always the physical type, this PR turns bit_vectorize() into an on/off switch, and all internal configuration parameters are renamed to is_bit_vectorized.

@netlify
Copy link

netlify bot commented Jul 5, 2022

Deploy Preview for docsite-preview canceled.

Name Link
🔨 Latest commit f2c6df1
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/62c3e1c07a0e53000877aa62

@strongoier strongoier requested review from ailzhang and k-ye July 5, 2022 08:20
Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@strongoier strongoier merged commit b3f7127 into taichi-dev:master Jul 5, 2022
@strongoier strongoier deleted the bit-vectorization-on-off branch July 5, 2022 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants