Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lang] Add errror message for missing init call #5280

Merged
merged 18 commits into from
Jul 1, 2022
Merged

[Lang] Add errror message for missing init call #5280

merged 18 commits into from
Jul 1, 2022

Conversation

neozhaoliang
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Jun 28, 2022 •
edited
Loading

✅ Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit 32c4893
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/62be89489012db0009ba67d0
😎 Deploy Preview https://deploy-preview-5280--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@neozhaoliang neozhaoliang changed the title [Lang] Add ifloor [Lang] Add ifloor and errror message for missing init call Jun 28, 2022
@neozhaoliang neozhaoliang changed the title [Lang] Add ifloor and errror message for missing init call [Lang] Change floor function and errror message for missing init call Jun 29, 2022
ailzhang
ailzhang suggested changes Jul 1, 2022
View reviewed changes
Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind splitting these to two PRs? Thanks!
(I feel like the change to floor is a bit tricky and this PR tries to fix two things in one place.

@neozhaoliang neozhaoliang changed the title [Lang] Change floor function and errror message for missing init call [Lang] Add errror message for missing init call Jul 1, 2022
@neozhaoliang
Copy link
Contributor Author

Would you mind splitting these to two PRs? Thanks! (I feel like the change to floor is a bit tricky and this PR tries to fix two things in one place.

Sure, it 's now split into two PRS.

ailzhang
ailzhang approved these changes Jul 1, 2022
View reviewed changes
Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
(Btw you'll have to fix pylint errors manually ;)

@neozhaoliang neozhaoliang requested a review from ailzhang July 1, 2022 05:44
@neozhaoliang
Copy link
Contributor Author

Fixed.

@ailzhang ailzhang merged commit 6f5eda9 into taichi-dev:master Jul 1, 2022
@neozhaoliang neozhaoliang deleted the add-ifloor branch July 1, 2022 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ailzhang ailzhang Awaiting requested review from ailzhang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neozhaoliang @ailzhang