Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[opengl] Move OpenGL backend onto Gfx runtime #5246

Merged
merged 11 commits into from
Jun 25, 2022

Conversation

bobcao3
Copy link
Collaborator

@bobcao3 bobcao3 commented Jun 24, 2022

No description provided.

@netlify
Copy link

netlify bot commented Jun 24, 2022

Deploy Preview for docsite-preview canceled.

Name Link
🔨 Latest commit 712131d
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/62b68fa03e09910008982426

Copy link
Contributor

@qiao-bo qiao-bo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! so much cleaner. So opengl_api is considered part of device code?

@bobcao3
Copy link
Collaborator Author

bobcao3 commented Jun 24, 2022

looks great! so much cleaner. So opengl_api is considered part of device code?

Yes, after the removal of the runtime part of the code.

Copy link
Member

@k-ye k-ye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bobcao3
Copy link
Collaborator Author

bobcao3 commented Jun 25, 2022

Seems to be a driver bug for Nvidia OpenGL #5259, disabled the polar decomposition test for OpenGL

@bobcao3 bobcao3 merged commit d0697e6 into taichi-dev:master Jun 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants